Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook subscription creation for SharePoint Libraries #2339

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

abraunegg
Copy link
Owner

  • Create a resource item using the driveId rather than specifying /me/drive/root

* Create a resource item using the driveId rather than specifying /me/drive/root
@abraunegg abraunegg added this to the v2.5.0 milestone Mar 15, 2023
src/onedrive.d Outdated Show resolved Hide resolved
* Update PR
@abraunegg abraunegg linked an issue Mar 17, 2023 that may be closed by this pull request
Copy link

@MouettE-SC MouettE-SC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for Sharepoint drives and does not seem to introduce regression in the webhook functionality.

@abraunegg abraunegg merged commit 6607ba5 into master Mar 17, 2023
@abraunegg abraunegg deleted the fix-issue-2337 branch March 17, 2023 23:03
@abraunegg
Copy link
Owner Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Mar 25, 2023
@abraunegg abraunegg modified the milestones: v2.5.0, v2.4.24 Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: webhook does not work with Sharepoint library
2 participants